Make the IPC tracks hidden by default during the first profile load#3908
Conversation
| height="400" | ||
| width="400" |
There was a problem hiding this comment.
Not sure why we don't have these anymore, but they are still not changed.
There was a problem hiding this comment.
I believe you need to call flushRafCalls(); after dispatching showLocalTrack.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3908 +/- ##
==========================================
- Coverage 88.63% 87.33% -1.30%
==========================================
Files 293 278 -15
Lines 25990 23774 -2216
Branches 6998 6272 -726
==========================================
- Hits 23035 20764 -2271
- Misses 2749 2771 +22
- Partials 206 239 +33
☔ View full report in Codecov by Sentry. |
julienw
left a comment
julienw
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me
| height="400" | ||
| width="400" |
There was a problem hiding this comment.
I believe you need to call flushRafCalls(); after dispatching showLocalTrack.
|
When I was working on IPC markers, I had decided to keep this PR open so it could be easier for me to work on them. But it's been a while since then and I forgot this PR. There is bug-1832144, which depends on this PR to land first. Let's land it now. Rebased it on top of the current main branch. |
2 participants
Fixes #3888.
Let's not make them visible by default, so they wouldn't take up a lot of space in the timeline. People still can always make them visible by using the tracks context menu if they are interested in them.
Example profile: production / deploy preview